Skip to content

Change the color of the warning links#5781

Merged
heiskr merged 3 commits intogithub:mainfrom
lucalves:hotfix/notices-link
Apr 27, 2021
Merged

Change the color of the warning links#5781
heiskr merged 3 commits intogithub:mainfrom
lucalves:hotfix/notices-link

Conversation

@lucalves
Copy link
Contributor

@lucalves lucalves commented Apr 27, 2021

Why:

As reported in Issue #5349, the color of the link in the notices is unreadable due to the blue background.
I changed it to the color -color-bg-info of premier.style.

With the change, it will look like this:

link-color

This will also affect documentation in Portuguese, Spanish and Japanese, in addition to Chinese.

Closes #5349.

What's being changed:

Check off the following:

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Apr 27, 2021
@lucalves lucalves mentioned this pull request Apr 27, 2021
Closed
@chiedo chiedo requested a review from heiskr April 27, 2021 19:48
@heiskr
Copy link
Contributor

heiskr commented Apr 27, 2021

I suspect we want to change the background color of the banner instead of the link color. 🙏🏼

@lucalves
Copy link
Contributor Author

lucalves commented Apr 27, 2021

I suspect we want to change the background color of the banner instead of the link color. 🙏🏼

Hi, @heiskr! I tested it by changing the background color and it really got better. However, I am not allowed to make this change, since the .css file that enables this change is inside the /dist folder and this folder is in the project's .gitignore file.

What to do in this situation?

@heiskr
Copy link
Contributor

heiskr commented Apr 27, 2021

I think the file you want to update is includes/header-notification.html, color-bg-info-inverse

@lucalves lucalves requested a review from a team as a code owner April 27, 2021 21:23
@lucalves
Copy link
Contributor Author

lucalves commented Apr 27, 2021 •
edited
Loading

I think the file you want to update is includes/header-notification.html, color-bg-info-inverse

You're right, thanks. I include the necessary changes.

@heiskr heiskr enabled auto-merge (squash) April 27, 2021 21:27
@heiskr heiskr merged commit e1ab94f into github:main Apr 27, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Apr 27, 2021

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

@adamlaska adamlaska mentioned this pull request Oct 8, 2024
Open
@sdgfffhgbcf sdgfffhgbcf mentioned this pull request Oct 8, 2024
Open
@kalbroni7 kalbroni7 mentioned this pull request Oct 8, 2024
Open
@AshdonG AshdonG mentioned this pull request Oct 8, 2024
Open
@Wrath77Firefox Wrath77Firefox mentioned this pull request Oct 9, 2024
Open
@Mdbabul41 Mdbabul41 mentioned this pull request Oct 9, 2024
Open
@vivandiu vivandiu mentioned this pull request Oct 9, 2024
Open
@Theo13111 Theo13111 mentioned this pull request Oct 9, 2024
Open
@mohammad-84 mohammad-84 mentioned this pull request Oct 9, 2024
Open
@rudaruda0 rudaruda0 mentioned this pull request Oct 9, 2024
Open
@pratapadi pratapadi mentioned this pull request Oct 9, 2024
Open
@acun87 acun87 mentioned this pull request Oct 9, 2024
Open
@otmaneEH otmaneEH mentioned this pull request Oct 9, 2024
Open
@SerchVet SerchVet mentioned this pull request Oct 9, 2024
Open
@zipzip225 zipzip225 mentioned this pull request Oct 9, 2024
Open
@zongruxie4 zongruxie4 mentioned this pull request Oct 14, 2024
Merged
@Sailayko Sailayko mentioned this pull request Oct 14, 2024
Open
@Verdinjoshua26 Verdinjoshua26 mentioned this pull request Oct 14, 2024
Open
@brandingfuture brandingfuture mentioned this pull request Oct 15, 2024
Open
@comunikatormiui comunikatormiui mentioned this pull request Oct 15, 2024
Open
@golfviva golfviva mentioned this pull request Oct 15, 2024
Open
@CALISOULB CALISOULB mentioned this pull request Oct 15, 2024
Open
@codywalker77 codywalker77 mentioned this pull request Oct 15, 2024
Open
@989919259920 989919259920 mentioned this pull request Oct 15, 2024
Open
@AshdonG AshdonG mentioned this pull request Oct 15, 2024
Open
@satoshinakamoto007 satoshinakamoto007 mentioned this pull request Oct 15, 2024
Open
@mongoloidkhulmikuki366385 mongoloidkhulmikuki366385 mentioned this pull request Oct 15, 2024
Open
@khmooz khmooz mentioned this pull request Oct 15, 2024
Open
@ASISBusiness ASISBusiness mentioned this pull request Oct 15, 2024
Open
@Visva92 Visva92 mentioned this pull request Oct 15, 2024
Open
@treeations treeations mentioned this pull request Oct 15, 2024
Open
@Miivaan Miivaan mentioned this pull request Oct 15, 2024
Open
@Jsn2win Jsn2win mentioned this pull request Oct 15, 2024
Open
@ghostfacepenetration ghostfacepenetration mentioned this pull request Oct 15, 2024
Open
@lilmoonlil lilmoonlil mentioned this pull request Oct 15, 2024
Open
@Z-byte-prog Z-byte-prog mentioned this pull request Oct 15, 2024
Closed
@arroselli arroselli mentioned this pull request Oct 15, 2024
Open
@abdulla134 abdulla134 mentioned this pull request Oct 15, 2024
Open
@Jccp1983 Jccp1983 mentioned this pull request Oct 15, 2024
Open
@snyk-io snyk-io bot mentioned this pull request Oct 15, 2024
Open
@gr00nd gr00nd mentioned this pull request Oct 15, 2024
Open
@Boybanri01 Boybanri01 mentioned this pull request Oct 16, 2024
Open
@Shariarnafiz Shariarnafiz mentioned this pull request Oct 16, 2024
Open
@Chantall1602 Chantall1602 mentioned this pull request Oct 17, 2024
Open
@sennhann29 sennhann29 mentioned this pull request Oct 21, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@heiskr heiskr heiskr approved these changes

Assignees

No one assigned

Labels

triage Do not begin working on this issue until triaged by the team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Blue link text in notices is unreadable due to blue background

2 participants

@lucalves @heiskr